Conversation
coszio
left a comment
There was a problem hiding this comment.
Still trying to wrap my head around this 🧠, left a few overview comments
|
|
||
| for _i in 0..num_vectors { | ||
| let mut links = Vec::new(); | ||
| let mut links = LinkContainer::default(); |
There was a problem hiding this comment.
links -> container? just aesthetic to avoid writing links.links
| } | ||
| } | ||
|
|
||
| fn select_one_candidate_with_heuristic_from_sorted<F>( |
There was a problem hiding this comment.
What's the main difference with respect to select_candidate_with_heuristic_from_sorted? I may not be in the loop here but the naming stands out a little ambiguous.
There was a problem hiding this comment.
I tried to explain main idea of PR in notions
https://www.notion.so/qdrant/Heuristic-optimization-ee4ff1ee35cc4ce2828ef87d09dd300b
| } | ||
|
|
||
| #[test] | ||
| fn test_optimized_heuristic() { |
There was a problem hiding this comment.
Are we keeping both the optimized + unoptimized versions available? Though it's nice that we can compare them for making sure they behave the same
There was a problem hiding this comment.
This change is very sensitive and I have to be sure that graph didn't change
|
Close this PR because it's simpler to reimplement this idea than fix all conflicts. Also, benchmarks are required |
All Submissions:
New Feature Submissions:
cargo fmtcommand prior to submission?cargo clippycommand?Changes to Core Features: