Skip to content

Fix: Timeout Precision in Remote Shard Queries#5496

Closed
varshith257 wants to merge 3 commits intoqdrant:devfrom
varshith257:fix-query-timeout
Closed

Fix: Timeout Precision in Remote Shard Queries#5496
varshith257 wants to merge 3 commits intoqdrant:devfrom
varshith257:fix-query-timeout

Conversation

@varshith257
Copy link
Copy Markdown
Contributor

@varshith257 varshith257 commented Nov 20, 2024 •
edited
Loading

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Fixes #5463
/claim #5463

Follow up to #5475 Discuusions

@algora-pbc algora-pbc bot mentioned this pull request Nov 20, 2024
Closed
@varshith257
Copy link
Copy Markdown
Contributor Author

varshith257 commented Nov 20, 2024

@timvisee Here's the clean PR! Sorry, I didn't have access to my desktop for the last 12 hours. So I have made review changes through my mobile lol :)

@varshith257
Copy link
Copy Markdown
Contributor Author

varshith257 commented Nov 22, 2024

@generall @timvisee Any reviews on this?

@generall
Copy link
Copy Markdown
Member

generall commented Nov 22, 2024

Hey @varshith257, thanks for the PR! Unfortunately, I think it doesn't cover all cases. For example request like

POST collections/test_collection/points/query/groups?timeout=1
{
    "group_by": "field-a",
    "query": 1,
    "with_lookup": {
        "collection": "test_collection"
    }
}

would still unexpectedly fail with the timeout.
For this reason I would prefer to go with this PR instead: #5495 it covers the timeout rounding in a more systematic way, and therefore it would be easier to spot the problem like this in future.

@generall
Copy link
Copy Markdown
Member

generall commented Nov 22, 2024

/tip $50

@algora-pbc
Copy link
Copy Markdown

algora-pbc bot commented Nov 22, 2024

👉 @generall: Navigate to your dashboard to proceed

@algora-pbc
Copy link
Copy Markdown

algora-pbc bot commented Nov 22, 2024

🎉🎈 @varshith257 has been awarded $50! 🎈🎊

@generall generall closed this Nov 22, 2024
@varshith257 varshith257 deleted the fix-query-timeout branch November 23, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🙋 Bounty claim 💰 Rewarded

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@varshith257 @generall