Skip to content

Add nop slf4j for tests#28

Merged
Anush008 merged 2 commits into
qdrant:masterfrom
russcam:russcam-noop-slf4j-tests
Apr 15, 2024
Merged

Add nop slf4j for tests#28
Anush008 merged 2 commits into
qdrant:masterfrom
russcam:russcam-noop-slf4j-tests

Conversation

@russcam

@russcam russcam commented Apr 15, 2024

Copy link
Copy Markdown
Collaborator

This PR adds nop slf4j test dependency, to suppress noProviders warning.

It also fixes a couple of small suggestions.

russcam added 2 commits April 15, 2024 17:49
This commit adds nop slf4j test dependency, to suppress noProviders warning.
@russcam russcam requested a review from Anush008 April 15, 2024 07:52
@russcam russcam changed the title Russcam noop slf4j tests Add nop slf4j for tests Apr 15, 2024

@Anush008 Anush008 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@Anush008 Anush008 merged commit 68729a5 into qdrant:master Apr 15, 2024
@russcam russcam deleted the russcam-noop-slf4j-tests branch April 15, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants