Skip to content

Expose gRPC client on high level client#27

Merged
Anush008 merged 1 commit into
qdrant:masterfrom
russcam:russcam-expose-grpcclient
Apr 15, 2024
Merged

Expose gRPC client on high level client#27
Anush008 merged 1 commit into
qdrant:masterfrom
russcam:russcam-expose-grpcclient

Conversation

@russcam

@russcam russcam commented Apr 15, 2024

Copy link
Copy Markdown
Collaborator

This commit exposes the low-level gRPC client on the high level client, for two purposes:

  • Allow access to the underlying gRPC channel. This may be useful for capturing properties about the channel e.g. the channel authority, for metrics.
  • Allow access to the gRPC client to make requests using the low-level gRPC client in cases where functionality may not yet be exposed by the higher level client.

This commit exposes the low-level gRPC client on the
high level client, for two purposes:

- Allow access to the underlying gRPC channel. This may be useful for capturing properties
  about the channel e.g. the channel authority, for metrics.
- Allow access to the gRPC client to make requests using the low-level gRPC
  client in cases where functionality may not yet be exposed by the higher level client.
@russcam russcam requested a review from Anush008 April 15, 2024 07:47

@Anush008 Anush008 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Anush008 Anush008 merged commit 9b202e4 into qdrant:master Apr 15, 2024
@russcam russcam deleted the russcam-expose-grpcclient branch April 15, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants