Skip to content

new: Add missing type hints#464

Merged
joein merged 5 commits into
mainfrom
mypy
Feb 6, 2025
Merged

new: Add missing type hints#464
joein merged 5 commits into
mainfrom
mypy

Conversation

@hh-space-invader

Copy link
Copy Markdown
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass the existing tests?
  • Have you added tests for your feature?
  • Have you installed pre-commit with pip3 install pre-commit and set up hooks with pre-commit install?

New models submission:

  • Have you added an explanation of why it's important to include this model?
  • Have you added tests for the new model? Were canonical values for tests computed via the original model?
  • Have you added the code snippet for how canonical values were computed?
  • Have you successfully ran tests with your changes locally?

@joein joein left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type ignoring each call to tokenizers does not seem to be right thing to do, is there a way to disable type checks for the library?

@joein joein self-requested a review February 6, 2025 15:23
@joein joein merged commit 0fa1596 into main Feb 6, 2025
@joein joein deleted the mypy branch February 6, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants