Rerank type hints#459
Merged
Merged
Conversation
da223f2 to
5bf11ce
Compare
joein
reviewed
Feb 4, 2025
|
|
||
| if isinstance(pairs, tuple): | ||
| pairs = [pairs] | ||
| pairs = list(pairs) |
Member
There was a problem hiding this comment.
the intended behaviour is
("Query_1", "Document_1") -> [("Query_1", "Document_1")]
not
("Query_1", "Document_1") -> ["Query_1", "Document_1"]
though, I understand that ("Query_1", "Document_1") is a violation of the type hint Iterable[tuple[str, str]], but I would rather not break this behaviour
5bf11ce to
ef28f51
Compare
joein
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
New Feature Submissions:
pre-commitwithpip3 install pre-commitand set up hooks withpre-commit install?New models submission: