Skip to content

Support jina embeddings v2 models#405

Merged
joein merged 2 commits into
mainfrom
support-jina-embeddings-v2-models
Nov 19, 2024
Merged

Support jina embeddings v2 models#405
joein merged 2 commits into
mainfrom
support-jina-embeddings-v2-models

Conversation

@hh-space-invader

@hh-space-invader hh-space-invader commented Nov 19, 2024

Copy link
Copy Markdown
Contributor

#402
Add support for:

  • jinaai/jina-embeddings-v2-base-zh
  • jinaai/jina-embeddings-v2-base-es

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass the existing tests?
  • Have you added tests for your feature?
  • Have you installed pre-commit with pip3 install pre-commit and set up hooks with pre-commit install?

New models submission:

  • Have you added an explanation of why it's important to include this model?
  • Have you added tests for the new model? Were canonical values for tests computed via the original model?
  • Have you added the code snippet for how canonical values were computed?
  • Have you successfully ran tests with your changes locally?

@joein joein merged commit e9dc3b1 into main Nov 19, 2024
@joein joein deleted the support-jina-embeddings-v2-models branch November 19, 2024 13:54
@I8dNLo I8dNLo mentioned this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants