Skip to content

new: drop python 3.8 support, update type hints, ci#403

Merged
joein merged 1 commit into
mainfrom
drop-python-3.8
Nov 15, 2024
Merged

new: drop python 3.8 support, update type hints, ci#403
joein merged 1 commit into
mainfrom
drop-python-3.8

Conversation

@joein

@joein joein commented Nov 15, 2024

Copy link
Copy Markdown
Member

Python3.8 reached it's end of life October 7th, this PR drops it support, and replaces type hins like typing.List, typing.Dict with the builtin structures e.g. list and dict

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Anush008 Anush008 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@joein joein merged commit 1343e55 into main Nov 15, 2024
@joein joein deleted the drop-python-3.8 branch November 15, 2024 14:54
@I8dNLo I8dNLo mentioned this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants