(draft) colpali WIP#394
Closed
I8dNLo wants to merge 29 commits into
Closed
Conversation
joein
requested changes
Nov 21, 2024
joein
requested changes
Nov 22, 2024
|
|
||
| supported_onnx_models = [ | ||
| { | ||
| "model": "akshayballal/colpali-v1.2-merged", |
Member
There was a problem hiding this comment.
can we use only text part of the model here?
Contributor
Author
There was a problem hiding this comment.
It's not really separated in our quantization. We could re-quantize it and separate, but I can not say it will have original behaviour. It could, but I'm not sure 100%
Member
There was a problem hiding this comment.
Which image model is used?
How much does it weight?
Does it make sense to split the models or the difference is negligible?
# Conflicts: # fastembed/late_interaction/colpali.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Colpali draft
Works for texts, does not work for images