Skip to content

Deprecate task.h in favor of qcorotask.h (#70)#76

Merged
danvratil merged 2 commits intomainfrom
deprecate-task-header
May 27, 2022
Merged

Deprecate task.h in favor of qcorotask.h (#70)#76
danvratil merged 2 commits intomainfrom
deprecate-task-header

Conversation

@danvratil
Copy link
Collaborator

The task.h (QCoro/Task) header is deprecated now and produces a warning
that users should switch to qcorotask.h (QCoro/QCoroTask) header. The
warning can be disabled by passing -DQCORO_NO_WARN_DEPRECATED_TASK_H
to the compiler. The header will be removed in some future versions of
QCoro.

@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2022

Unit Test Results

  16 files  +  2    16 suites  +2   11m 53s ⏱️ + 1m 36s
  16 tests ±  0    15 ✔️  -   1  0 💤 ±0  1 +1 
252 runs  +32  248 ✔️ +28  0 💤 ±0  4 +4 

For more details on these failures, see this check.

Results for commit f7466b3. ± Comparison against base commit df058a9.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
test-task ‑ test-task
test-qcorotask ‑ test-qcorotask

♻️ This comment has been updated with latest results.

The task.h (QCoro/Task) header is deprecated now and produces a warning
that users should switch to qcorotask.h (QCoro/QCoroTask) header. The
warning can be disabled by passing -DQCORO_NO_WARN_DEPRECATED_TASK_H
to the compiler. The header will be removed in some future versions of
QCoro.
@danvratil danvratil force-pushed the deprecate-task-header branch 2 times, most recently from 8b31d88 to df92323 Compare May 21, 2022 10:29
@danvratil danvratil force-pushed the deprecate-task-header branch from 8b31d88 to f7466b3 Compare May 21, 2022 10:52
@danvratil danvratil merged commit 960fb2a into main May 27, 2022
@danvratil danvratil deleted the deprecate-task-header branch May 27, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant