Rework Github CI - add compilers and platforms#60
Merged
Conversation
8ddbac2 to
6d1d7f5
Compare
Contributor
1ea2669 to
97c4801
Compare
4cb544e to
dd7c038
Compare
Add multiple versions of GCC, clang, add apple-clang.
The socket state is local, so it's possible to report 'connected', resume to coroutine finish it and destroy the socket before the server has time to actually get the incoming connection. This results in the test server being stopped by the test before it actually starts waiting for incoming connection, causing the server to incorrectly report the test as time out. The fix is for the test to wait at the end for the server to confirm it has gotten the incoming connection.
libc++ doesn't implement any concepts yet, use variable templates instead.
…nnectedSocket The test server expects a request and if none arrives, it fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add multiple versions of GCC, clang, add apple-clang.