Add regression test for QFuture awaiter destroyed before completion#317
Closed
Copilot wants to merge 7 commits into312-fix-qcorofuture-memory-leakfrom
Closed
Add regression test for QFuture awaiter destroyed before completion#317Copilot wants to merge 7 commits into312-fix-qcorofuture-memory-leakfrom
Copilot wants to merge 7 commits into312-fix-qcorofuture-memory-leakfrom
Conversation
Co-authored-by: danvratil <932001+danvratil@users.noreply.github.com>
Co-authored-by: danvratil <932001+danvratil@users.noreply.github.com>
Co-authored-by: danvratil <932001+danvratil@users.noreply.github.com>
Co-authored-by: danvratil <932001+danvratil@users.noreply.github.com>
Co-authored-by: danvratil <932001+danvratil@users.noreply.github.com>
f9284bb to
a23a64f
Compare
Copilot
AI
changed the title
[WIP] Fix review comments on memory leak fix in QFuture coro wrapper
Add regression test for QFuture awaiter destroyed before completion
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #316 fixed a memory leak when a coroutine awaiting a QFuture is destroyed before the future completes. This PR adds a regression test for that scenario.
Test coverage
testAwaiterDestroyedBeforeFutureFinishes): Creates a QFuture, starts a coroutine that co_awaits it, destroys the coroutine before the future completes, then completes the future. Verifies:The test exercises the fix where QFutureWatcher is parented to the awaiter's dummy QObject, ensuring cleanup when the awaiter is destroyed.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.