Use dbus-run-session to run D-Bus tests instead of dbus-launch#300
Merged
danvratil merged 1 commit intoqcoro:mainfrom Dec 10, 2025
Merged
Use dbus-run-session to run D-Bus tests instead of dbus-launch#300danvratil merged 1 commit intoqcoro:mainfrom
danvratil merged 1 commit intoqcoro:mainfrom
Conversation
dbus-run-session spawns a session that gets terminated automatically after the execution of the command. It is a simpler way compared to dbus-launch, which relies on the X11 tolaunching (which would explain why it is not used on macOS, as the comment says). Hence, use dbus-run-session instead of dbus-launch to run each D-Bus test. Keep the existing macOS behaviour as-is for now, adding a comment to test using dbus-run-session in the future.
6fa4905 to
de4b256
Compare
Collaborator
|
Hi Pino, thanks for the patch! And sorry it took so long to get it merged :) Don't worry about the failing Windows build, somehow dbus completely disappeared from the Windows CI image :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dbus-run-sessionspawns a session that gets terminated automatically after the execution of the command. It is a simpler way compared todbus-launch, which relies on the X11 tolaunching (which would explain why it is not used on macOS, as the comment says).Hence, use
dbus-run-sessioninstead ofdbus-launchto run each D-Bus test. Keep the existing macOS behaviour as-is for now, adding a comment to test usingdbus-run-sessionin the future.