Merged
Conversation
Collaborator
|
Thanks for the patch. Looking at the CI, I think we will need to skip the line you removed only conditionally if Qt >= 6.9 (or 6.10? Not sure what the dev is now with 6.9 just around the corner). Would you mind updating the patch, please? |
Contributor
Author
|
Hmm, it looks like we need to put |
Contributor
Author
|
I'll split the find_package() line in two: one for public components, and another for private components. We should know the Qt version after the first find_package() |
d27437d to
de81f86
Compare
Contributor
Author
|
Let's see if this passes CI. Another option would be to add a new option, e.g. |
With Qt dev, private components are no longer implicitly searched for by find_package(), they should be listed explicitly. Currently, qcoro_find_qt() excludes the private components from find_package() so qcoro fails to build due to "unknown" components such as Qt::QmlPrivate.
de81f86 to
ffbfc77
Compare
Collaborator
|
Perfect, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Qt dev, private components are no longer implicitly searched for by find_package(), they should be listed explicitly.
Currently, qcoro_find_qt() excludes the private components from find_package() so qcoro fails to build due to "unknown" components such as Qt::QmlPrivate.