Fix infinite recursion with debug builds on libstdc++#268
Merged
danvratil merged 1 commit intoqcoro:mainfrom Mar 16, 2025
Merged
Fix infinite recursion with debug builds on libstdc++#268danvratil merged 1 commit intoqcoro:mainfrom
danvratil merged 1 commit intoqcoro:mainfrom
Conversation
danvratil
approved these changes
Mar 16, 2025
Collaborator
danvratil
left a comment
There was a problem hiding this comment.
Indeed, the comparison to nullptr probably triggers some crazy chain of implicit conversions. Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On GCC 14.2.1 and libstdc++, during await_resume this comparison in taskbase.h:
seems to hit an infinite recursion in std::expected here:
for this template instance:
std::operator==<std::coroutine_handle<QCoro::detail::TaskPromise<std::expected<A, B>>>>where A and B are types used in my code.
I am not sure where the left-hand std::expected comes from, but it seems like the multiple implicit conversions that need to happen here (coroutine_handle to coroutine_handle<>, nullptr_t to coroutine_handle<>) cause sufficient ambiguity for GCC to perform the comparison in an unexpected way.
This is fixed if I change this to an implicit conversion to bool instead, as is done elsewhere in this file.