fix: disable language-extension-token warning#266
Merged
danvratil merged 1 commit intoqcoro:mainfrom Feb 25, 2025
ptsouchlos:PT/fix-build-flags
Merged
fix: disable language-extension-token warning#266danvratil merged 1 commit intoqcoro:mainfrom ptsouchlos:PT/fix-build-flags
danvratil merged 1 commit intoqcoro:mainfrom
ptsouchlos:PT/fix-build-flags
Conversation
This warning breaks downstream builds because of how QCoro sets the compiler flags. A better solution would be for QCoro to set compiler flags using the `target_compile_options()` function for unit testing targets.
danvratil
approved these changes
Feb 25, 2025
Collaborator
danvratil
left a comment
There was a problem hiding this comment.
Thanks for the fix, Paul. Sorry I did not get back to you sooner.
Good point with setting the flags only for the tests, I'll address that separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This warning breaks downstream builds because of how QCoro sets the compiler flags. A better solution would be for QCoro to set compiler flags using the
target_compile_options()function for unit testing targets.Resolves #265