Conversation
Instead of a single bool that tells us whether we can destroy the coroutine safely, we now use a ref-count and destroy the coroutine when the count drops to 0. Generally, a coroutine has ref count value of 2 - one is held by the coroutine itself (ensuring it's not deleted until it finishes) and one is held by QCoro::Task, ensuring we can access the coroutine state as long as the corresponding Task exists. This also opens doors to future enhancements, like SharedTasks that can be safely co_awaited by multiple awaiters.
eb25c96 to
a46e73d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of a single bool that tells us whether we can destroy the coroutine safely, we now use a ref-count and destroy the coroutine when the count drops to 0. Generally, a coroutine has ref count value of 2 - one is held by the coroutine itself (ensuring it's not deleted until it finishes) and one is held by QCoro::Task, ensuring we can access the coroutine state as long as the corresponding Task exists.
This also opens doors to future enhancements, like SharedTasks that can be safely co_awaited by multiple awaiters.