Suppress Clang error when building against Android NDK <= 25#205
Merged
Suppress Clang error when building against Android NDK <= 25#205
Conversation
Android NDK <= 25 ships mismatching version of clang and libc++. The libc++ in the NDK is old and doesn't support coroutines, which forces us to fallback to using coroutines from std::experimental namespace. However, the clang version is newer and causes a compile error when using coroutines from std::experimental, because as of LLVM 14, coroutines are fully implemented. To suppresss the error, we must set a special compile option. This is fixed with NDK 26, which now ships libc++ from LLVM toolchain, so the version matches the compiler version (and they updated to LLVM 17 with full coroutine support). Resolves issue #204.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android NDK <= 25 ships mismatching version of clang and libc++. The libc++ in the NDK is old and doesn't support coroutines, which forces us to fallback to using coroutines from std::experimental namespace. However, the clang version is newer and causes a compile error when using coroutines from std::experimental, because as of LLVM 14, coroutines are fully implemented.
To suppresss the error, we must set a special compile option. This is fixed with NDK 26, which now ships libc++ from LLVM toolchain, so the version matches the compiler version (and they updated to LLVM 17 with full coroutine support).
Resolves issue #204.