Add support for connecting signals with QPrivateSignal#193
Merged
Conversation
f5481d3 to
f3335f8
Compare
774cb62 to
74b69a8
Compare
Initial commit that adds support for co_awaiting signals with
QPrivateSignal in their signature ("private signals"). This
basically requries detecting the QPrivateSignal type in the
arguments and omitting it when preparing the holder for
signal parameters and when storing the signal parameters
into the result holder.
Currently the QPrivateSignal detection is using a bit whacky
hack, but I couldn't figure out anything better due to the
QPrivateSignal always being a private struct in the sender
class, so we cannot access it from QCoro to do e.g. std::same_as
check.
74b69a8 to
6e2aba2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial commit that adds support for co_awaiting signals with QPrivateSignal in their signature ("private signals"). This basically requries detecting the QPrivateSignal type in the arguments and omitting it when preparing the holder for signal parameters and when storing the signal parameters into the result holder.
Currently the QPrivateSignal detection is using a bit whacky hack, but I couldn't figure out anything better due to the QPrivateSignal always being a private struct in the sender class, so we cannot access it from QCoro to do e.g. std::same_as check.