qcorowebsocket replace QWebSocket::error with QWebSocket::errorOccurred#174
Merged
danvratil merged 1 commit intoqcoro:mainfrom May 13, 2023
nmariusp:work/nmariusp/errorOccured
Merged
qcorowebsocket replace QWebSocket::error with QWebSocket::errorOccurred#174danvratil merged 1 commit intoqcoro:mainfrom nmariusp:work/nmariusp/errorOccured
danvratil merged 1 commit intoqcoro:mainfrom
nmariusp:work/nmariusp/errorOccured
Conversation
danvratil
requested changes
May 13, 2023
Collaborator
danvratil
left a comment
There was a problem hiding this comment.
Thanks for the patch. This will need an #ifdef for Qt>=6.5, when the new signal was introduced. And you can remove the qOverload, since there won't be an ambiguity between the signal and a getter anymore.
Contributor
Author
|
OK. |
I build using cmake build configuration "Debug" not "RelWithDebInfo".
Building qcoro fails with error "qcoro/qcoro/websockets/qcorowebsocket.cpp:
35:73: error: ‘void QWebSocket::error(QAbstractSocket::SocketError)’
is deprecated: Use errorOccurred instead [-Werror=deprecated-declarations]".
Because "# Only enable strict warnings in debug mode
set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -Wall -Wextra -Werror -pedantic")".
danvratil
approved these changes
May 13, 2023
Collaborator
danvratil
left a comment
There was a problem hiding this comment.
Looks good now, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I build using cmake build configuration "Debug" not "RelWithDebInfo".
Building qcoro fails with error "qcoro/qcoro/websockets/qcorowebsocket.cpp: 35:73: error: ‘void QWebSocket::error(QAbstractSocket::SocketError)’ is deprecated: Use errorOccurred instead [-Werror=deprecated-declarations]".
Because "# Only enable strict warnings in debug mode
set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -Wall -Wextra -Werror -pedantic")".