QML: Add declarative API for awaiting a task#170
Merged
danvratil merged 2 commits intoqcoro:mainfrom Apr 24, 2023
Merged
Conversation
d54a502 to
5922757
Compare
Collaborator
|
Oooo, that is super-clever! I love it! Do you think there's a use-case for an optional default "awaiting" value? e.g.: Where the value of the |
danvratil
requested changes
Apr 24, 2023
Contributor
Author
That looks like a very good idea! |
5922757 to
474b7df
Compare
38ba13c to
141219e
Compare
danvratil
approved these changes
Apr 24, 2023
Collaborator
danvratil
left a comment
There was a problem hiding this comment.
Awesome! Great work. Thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal for a bit nicer API for awaiting. In exchange for being a bit heavier, it allows declarative usage.