Make how Qt packages are found more convinient#162
Merged
danvratil merged 1 commit intoqcoro:mainfrom Apr 7, 2023
ptsouchlos:feature/qt-find
Merged
Make how Qt packages are found more convinient#162danvratil merged 1 commit intoqcoro:mainfrom ptsouchlos:feature/qt-find
danvratil merged 1 commit intoqcoro:mainfrom
ptsouchlos:feature/qt-find
Conversation
This change allows users to specify `Qt5_DIR` or `Qt6_DIR` and then the rest of the components are automatically found. Prior to this, since `find_package()` was called for each component of Qt, CMake configuring would fail with each component not found. So you would have to specify all the paths at once.
Collaborator
|
Thanks, Paul! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows users to specify
Qt5_DIRorQt6_DIRand then the rest of the components are automatically found. Prior to this, sincefind_package()was called for each component of Qt, CMake configuring would fail with each component not found. So you would have to specify all the paths at once.I'm not sure if
find_package(Qt${ARGS_QT_VERSION}${base_component} REQUIRED COMPONENTS Private)is needed, but if so I can add it back in. From my testing, things worked as expected.