Make QCoro::Generator<T> properly move-constructible#151
Merged
danvratil merged 1 commit intoqcoro:mainfrom Feb 21, 2023
Merged
Make QCoro::Generator<T> properly move-constructible#151danvratil merged 1 commit intoqcoro:mainfrom
danvratil merged 1 commit intoqcoro:mainfrom
Conversation
Collaborator
|
Thanks a lot for the patch (and sorry for the delayed review!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QCoro::Generator<T>is currently not properly move-constructible, as the move constructor holds a reference to the existingstd::coroutine_handle, destroying it when the original generator is destroyed.This PR creates a custom move constructor for
QCoro::Generator<T>in order to properly move-construct it.