Merged
Conversation
Contributor
jbruechert
commented
Nov 19, 2022
- Member function pointers are now allowed as callback
- Any awaitable can now be connected to.
- It's now possible to pass temporaries to connect, as they previously couldn't passed in by mutable reference
8245219 to
4e14248
Compare
danvratil
requested changes
Nov 19, 2022
Collaborator
danvratil
left a comment
There was a problem hiding this comment.
Nice job, thanks!
Just some smaller nitpicks to fix and what I suspect is a missing test-case :)
4e14248 to
8325b6f
Compare
danvratil
reviewed
Nov 19, 2022
- Member function pointers are now allowed as callback - Any awaitable can now be connected to.
8325b6f to
8f719cd
Compare
danvratil
approved these changes
Nov 19, 2022
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.