Merged
Conversation
2f36f6a to
fa37e3f
Compare
danvratil
requested changes
Aug 16, 2022
Collaborator
There was a problem hiding this comment.
Nice, thanks for upstreaming this! Looks OK, just two small nitpicks.
Also please update .github/workflows/generate-matrix.py and add qtdeclarative to "archives" field for both Qt5 and Qt6 maps (at the beginning of the file), that should make the pipelines pass.
If you are interested in writing a unit-test for the class as well, I'd appreciate it (you can do it in another PR), but it's not requirement (I'll write it later).
600289e to
9570dd6
Compare
Collaborator
|
The CI is failing on Linux because I forgot that the Docker images used in the CI don't contain the qtdeclarative module. I've rebuild the images, so the next run should succeed. |
danvratil
approved these changes
Aug 16, 2022
Collaborator
|
Could you please rebase on current |
QCoro::ImageProvider is a coroutine-compatible wrapper around QQuickAsyncImageProvier. This commit introduces a new QCoro component, QCoroQuick.
9570dd6 to
8385e0a
Compare
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for starting another pull request in parallel :)
I already had this code in a project of mine and think it might be useful to upstream.