Skip to content

Compile definitions leak into consumer applications #274

@nicolasfella

Description

@nicolasfella

Since recently compile defintions like QT_NO_CAST_FROM_ASCII or QT_NO_KEYWORDS that QCoro sets internally also leak into consumer applications due to using PUBLIC/INTERFACE in CMake.

This is not nice and can cause build failures in downstream projects.

Tested with QCoro at 124858b

This affects for example plasma-nm and kio-extras

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions