Skip to content

Implement EIP712 array encoding#361

Merged
q9f merged 2 commits intomainfrom
ll0sbi-codex/implement-eip712-arrays-and-fix-tests
Aug 6, 2025
Merged

Implement EIP712 array encoding#361
q9f merged 2 commits intomainfrom
ll0sbi-codex/implement-eip712-arrays-and-fix-tests

Conversation

@q9f
Copy link
Owner

@q9f q9f commented Aug 6, 2025

  • support arrays in EIP-712 type dependency detection and encoding
  • enable SellOrders typed-data test by removing pending flag
  • prevent catastrophic regex backtracking and expand encode_array coverage
  • eliminate polynomial regex in EIP-712 array and dependency parsing
  • fix Arrays currently unimplemented for EIP-712 #127

@q9f q9f added the codex Codex is a durable, decentralised data storage protocol label Aug 6, 2025 — with ChatGPT Codex Connector
@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.59%. Comparing base (f0cd47f) to head (b21179d).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #361    +/-   ##
========================================
  Coverage   99.58%   99.59%            
========================================
  Files          85       87     +2     
  Lines        5971     6098   +127     
========================================
+ Hits         5946     6073   +127     
  Misses         25       25            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@q9f q9f merged commit 61bcd2b into main Aug 6, 2025
8 checks passed
@q9f q9f deleted the ll0sbi-codex/implement-eip712-arrays-and-fix-tests branch August 6, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex Codex is a durable, decentralised data storage protocol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Arrays currently unimplemented for EIP-712

1 participant