Skip to content

Move error decoding to contract module#350

Merged
q9f merged 2 commits intomainfrom
codex/move-decode_contract_error-to-contract-module
Aug 4, 2025
Merged

Move error decoding to contract module#350
q9f merged 2 commits intomainfrom
codex/move-decode_contract_error-to-contract-module

Conversation

@q9f
Copy link
Owner

@q9f q9f commented Aug 4, 2025

  • move error decoding logic into Eth::Contract#decode_error
  • delegate error handling in Eth::Client to the contract
  • add spec for Contract#decode_error

@q9f q9f added the codex Codex is a durable, decentralised data storage protocol label Aug 4, 2025 — with ChatGPT Codex Connector
@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@895f78e). Learn more about missing BASE report.
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lib/eth/contract.rb 85.71% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #350   +/-   ##
=======================================
  Coverage        ?   99.03%           
=======================================
  Files           ?       85           
  Lines           ?     5705           
  Branches        ?        0           
=======================================
  Hits            ?     5650           
  Misses          ?       55           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@q9f q9f merged commit 372e7ea into main Aug 4, 2025
8 checks passed
@q9f q9f deleted the codex/move-decode_contract_error-to-contract-module branch August 4, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex Codex is a durable, decentralised data storage protocol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant