Merged
Conversation
q9f
reviewed
Nov 22, 2023
| "#{name}(#{types.join(",")})" | ||
| end | ||
|
|
||
| def type(input) |
Owner
There was a problem hiding this comment.
can you add basic docs to the method? 🙏🏼
q9f
reviewed
Nov 22, 2023
| if input["type"] == "tuple" | ||
| "(#{input["components"].map {|c| type(c) }.join(",")})" | ||
| elsif input["type"] == "enum" | ||
| "uint8" |
Owner
There was a problem hiding this comment.
can you provide a test case for tuple and enum so I can make sure not to break it in future?
q9f
reviewed
Nov 22, 2023
Owner
q9f
left a comment
There was a problem hiding this comment.
Ignore the failing spec, it does not work on CI due to permissions.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
=======================================
Coverage ? 99.44%
=======================================
Files ? 77
Lines ? 4483
Branches ? 0
=======================================
Hits ? 4458
Misses ? 25
Partials ? 0 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.