Skip to content

eth/util: fix compressed public key to address#206

Merged
q9f merged 1 commit intoq9f:mainfrom
an-lee:main
Jan 9, 2023
Merged

eth/util: fix compressed public key to address#206
q9f merged 1 commit intoq9f:mainfrom
an-lee:main

Conversation

@an-lee
Copy link
Contributor

@an-lee an-lee commented Jan 8, 2023

fix #205

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2023

Codecov Report

Merging #206 (6d73bca) into main (75a0036) will decrease coverage by 0.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
- Coverage   99.77%   99.51%   -0.26%     
==========================================
  Files          77       77              
  Lines        4358     4361       +3     
==========================================
- Hits         4348     4340       -8     
- Misses         10       21      +11     
Impacted Files Coverage Δ
lib/eth/util.rb 100.00% <100.00%> (ø)
spec/eth/util_spec.rb 100.00% <100.00%> (ø)
spec/eth/ens/resolver_spec.rb 83.78% <0.00%> (-16.22%) ⬇️
lib/eth/ens/resolver.rb 85.29% <0.00%> (-14.71%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@q9f
Copy link
Owner

q9f commented Jan 9, 2023

Tests only fail because the secret is not available. Passes locally and LGTM!

@q9f q9f merged commit 5f37cd4 into q9f:main Jan 9, 2023
@q9f q9f added the bug Something isn't working label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Compressed public key to the wrong address

3 participants