Skip to content

eth/client: correctly select functions#191

Merged
q9f merged 2 commits intomainfrom
q9f/client/func
Dec 28, 2022
Merged

eth/client: correctly select functions#191
q9f merged 2 commits intomainfrom
q9f/client/func

Conversation

@q9f
Copy link
Owner

@q9f q9f commented Dec 28, 2022

if multiple overloads of a solidity function exist, this selects the correct one.

also adds an infura mainnet API to the spec tests.

@q9f q9f added the bug Something isn't working label Dec 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2022

Codecov Report

Merging #191 (9e186ff) into main (91409f4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #191   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          70       70           
  Lines        4241     4253   +12     
=======================================
+ Hits         4231     4243   +12     
  Misses         10       10           
Impacted Files Coverage Δ
lib/eth/client.rb 100.00% <100.00%> (ø)
spec/eth/client_spec.rb 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants