Skip to content

eth/client: dup params to prevent marshalling on client obj#184

Merged
q9f merged 1 commit intomainfrom
q9f/client/dup
Dec 21, 2022
Merged

eth/client: dup params to prevent marshalling on client obj#184
q9f merged 1 commit intomainfrom
q9f/client/dup

Conversation

@q9f
Copy link
Owner

@q9f q9f commented Dec 21, 2022

fix #174

@q9f q9f added the bug Something isn't working label Dec 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2022

Codecov Report

Merging #184 (170857d) into main (1633ed0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #184   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files          70       70           
  Lines        4077     4082    +5     
=======================================
+ Hits         4065     4070    +5     
  Misses         12       12           
Impacted Files Coverage Δ
lib/eth/client.rb 98.75% <100.00%> (+<0.01%) ⬆️
spec/eth/client_spec.rb 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@q9f q9f merged commit 9e3e2af into main Dec 21, 2022
@q9f q9f deleted the q9f/client/dup branch December 21, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected argument mutation

2 participants