Conversation
kurotaky
reviewed
Dec 11, 2022
kurotaky
reviewed
Dec 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #173 +/- ##
==========================================
- Coverage 99.75% 99.70% -0.05%
==========================================
Files 70 70
Lines 4016 4061 +45
==========================================
+ Hits 4006 4049 +43
- Misses 10 12 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
hey @kurotaky, the build in Ubuntu is failing because it lacks |
Owner
|
Thanks, I'll fix the CI. |
q9f
approved these changes
Dec 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a method to check if transaction has succeeded.
Also took the opportunity to change the name of
is_mined_tx?->tx_mined?to be closer to Ruby conventions (boolean methods with?withoutis_)