Conversation
q9f
approved these changes
Nov 26, 2022
lib/eth/client.rb
Outdated
| # @param **nonce [Integer] optional specific nonce for transaction. | ||
| # @return [String] the local transaction hash. | ||
| def transfer(destination, amount, sender_key = nil, legacy = false) | ||
| def transfer(destination, amount, sender_key = nil, legacy = false, **kwargs) |
Owner
There was a problem hiding this comment.
Do you mind tow rewrite the sender key and legacy transaction toggle to kwargs too? I meant to do this for a while. 🙏🏼
Contributor
Author
There was a problem hiding this comment.
I thought about it, but it will crash backward compatibility.
Ok, I will do next steps for this PR:
- move some args to kwargs
- code quality
- conflicts resolving
Codecov Report
@@ Coverage Diff @@
## main #169 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 70 70
Lines 4023 4058 +35
=======================================
+ Hits 4013 4048 +35
Misses 10 10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Prev commit bug fix + codestyle fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes we need to replace already submitted pending tx, or plan our work with creating array of transactions to send, and it requires manual setting of nonce value. This PR give ability to set tx nonce manually.