Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8343 +/- ##
==========================================
- Coverage 96.60% 96.59% -0.01%
==========================================
Files 160 160
Lines 34733 34733
Branches 4390 4390
==========================================
- Hits 33554 33552 -2
- Misses 573 574 +1
- Partials 606 607 +1 |
Contributor
7085aea to
41ecbe3
Compare
41ecbe3 to
66a8173
Compare
Collaborator
Author
|
This has been fixed in tox-dev/tox#3753 so this PR is not needed once latest tox is released |
Contributor
|
Thanks @edabor. This is fixed with v4.42 https://github.com/tox-dev/tox/releases/tag/4.42.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
From local testing, I saw that tox
>=4.39is causing those issues.I suspect tox-dev/tox#3753 being the root cause.
It does not occur for Linux CI since it uses a local pypi https://github.com/pyvista/pyvista/actions/runs/22188242201/job/64168341258?pr=8195#step:6:21
I'm investigating, but as an interim solution we can upper-pin
toxOriginally posted by @edabor in #8195 (comment)
This PR is an attempt to fix compatibility with latest
tox