Conversation
import pyvista as pv
def picked_cells(subgrid):
pass
grid = pv.UniformGrid((10, 20, 5))
plotter = pv.Plotter(notebook=False)
plotter.add_mesh(grid, show_edges=True, style="surface")
plotter.enable_cell_picking(callback=picked_cells, through=False)
plotter.show()
|
|
FYI I took out the warnings about non-NVIDIA GPUs because I don't think that is relevant anymore. Also, I was testing this on a Radeon GPU and it worked beautifully. |
|
@akaszynski, I'm thinking we should cherrypick this onto the release branch if testing comes back good (from you and/or @rodrigomologni locally, please???) |
|
All for cherrypicking this and pushing a patch release. We need to add in the sdist patch as well. Would you like to make a PR containing this and the sdist commit? |
akaszynski
left a comment
There was a problem hiding this comment.
It's not intuitive that you had to generate a surface mesh and triangulate it. Nice job for figuring it out!
|
@banesullivan, sorry for the delay. I was offline for a few days. I ran the code with your changes in Windows 10 with AMD Radeon and NVIDIA too. The bug was fixed in both. Thank you! :-) |
|
@banesullivan, your bug fix is not working in VTK 8.2.1. Nothing happens when I to press R or P. I tested only in AMD Radeon. :-( |
|
Ugh, thanks for reporting that... and good thing we didn't ship it yet |
|
@rodrigomologni, I was able to confirm this... it appears to me this is a bug with |
|
In the release notes for VTK8.2, it mentions how the hardware selector was massively reworked/improved. It seems we are using the API for those improvements... I can try to make this backward compatible but no guarantees |
|
Yeah.... it looks complicated. need to set up the mappers constantly sync their data to the GPU I think. This seems like a big task for backward compat... maybe you can use a more up to date version of VTK? 😉 |
|
@banesullivan all right! Let's think about the future. VTK 9 is the future! I'm already using VTK 9. 😉 |
Overview
This fixes all the issues we were having with visible cell picking 🎉
resolves pyvista/pyvista-support#177
Details
In summary:
vtkSelectionNodewas giving us the cell IDs after running avtkDataSetSurfaceFilterand avtkTriangleFilter. So we have to mimic that pipeline to map the selected cells back to the original mesh. Easy-peasy once I thought about it a little bit...An important note... the representation style MUST be
surface!!!!!!!!!! Usingwireframeor points will break this pipeline. I added a warning for this.