Fix screenshots for Sphinx Gallery#782
Merged
banesullivan merged 1 commit intorelease/0.25from Jun 6, 2020
Merged
Conversation
Member
|
This is a clever fix! Let me think about this one a bit more before we merge and release. Thanks for getting to this so quickly, @akaszynski! |
banesullivan
approved these changes
Jun 6, 2020
Member
banesullivan
left a comment
There was a problem hiding this comment.
Need a fix ASAP for the Tranfrom2020 hackathons. Merging and releasing
Member
|
Actually. I am going to document this real fast |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many projects use
pyvistaforsphinx_galleryand this PR seeks to keep the past behavior without sacrificing performance by unnecessarily always saving screenshots.On initialization,
pyvistachecks ifsphinxhas been imported. If it has, screenshots are automatically saved upon the closing of a plot.Follow up to #730