Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #618 +/- ##
==========================================
- Coverage 83.9% 83.82% -0.08%
==========================================
Files 32 32
Lines 9075 9075
==========================================
- Hits 7614 7607 -7
- Misses 1461 1468 +7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Resolve #617
Resolve pyvista/pyvista-support#128
Resolve pyvista/pyvista-support#123
Details
Depth peeling has issues with some VTK versions and some OS. It also is known to segfault, so we should disable this by default.