Select type of event for slider widget#514
Merged
GuillaumeFavelier merged 2 commits intomasterfrom Dec 23, 2019
Merged
Conversation
5 tasks
Contributor
Author
|
Let me know what you think @banesullivan |
akaszynski
approved these changes
Dec 22, 2019
Contributor
Author
|
+1 for real interactive testing but I don't know where to start |
banesullivan
approved these changes
Dec 22, 2019
Member
|
Interactive testing is definitely needed for the widgets, picking features, and more... perhaps down the road, we can implement a module for automatically interacting with all of these features |
Member
|
This looks good to me! |
Member
|
@GuillaumeFavelier, you should have full "maintainer" access now, so feel free to merge when you're ready |
Contributor
Author
|
Wow! Thank you so much! Okay I'll merge then |
Contributor
Author
|
Whoops, I forgot to edit the commit message before merging. I'll be careful from now on, sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the user to specify how often the slider interacts with the callback.