Skip to content

Fix slider widget coordinate parameters#511

Merged
banesullivan merged 1 commit intomasterfrom
fix_add_slider_widget
Dec 19, 2019
Merged

Fix slider widget coordinate parameters#511
banesullivan merged 1 commit intomasterfrom
fix_add_slider_widget

Conversation

@GuillaumeFavelier
Copy link
Copy Markdown
Contributor

@GuillaumeFavelier GuillaumeFavelier commented Dec 19, 2019

This PR fixes a bug with the input coordinates of the slider widget.

To reproduce:

import pyvista as pv


def foo(v):
    pass


rng = [0, 1]
left = [[0.1, -0.3],
        [0.1, 1.3]]
right = [[0.9, -0.3],
         [0.9, 1.3]]
p = pv.Plotter()
p.add_slider_widget(foo, rng=rng, title='left', pointa=left[0], pointb=left[1])
p.add_slider_widget(foo, rng=rng, title='right', pointa=right[0], pointb=right[1])
p.show()
master PR
2019-12-19_1920x1080 2019-12-19_1920x1080

@GuillaumeFavelier GuillaumeFavelier self-assigned this Dec 19, 2019
@GuillaumeFavelier
Copy link
Copy Markdown
Contributor Author

GuillaumeFavelier commented Dec 19, 2019

Also I expected the normalized coordinate system to be between 0 and 1 but for some reason, the y-axis doesn't respect this rule.

@banesullivan
Copy link
Copy Markdown
Member

banesullivan commented Dec 19, 2019

Thanks for fixing this!

@GuillaumeFavelier
Copy link
Copy Markdown
Contributor Author

GuillaumeFavelier commented Dec 19, 2019

Also a render to describe the different components of the slider:

2019-12-19_1920x1080

@banesullivan
Copy link
Copy Markdown
Member

banesullivan commented Dec 19, 2019

@GuillaumeFavelier, squash and merge this whenever you're ready

@GuillaumeFavelier
Copy link
Copy Markdown
Contributor Author

GuillaumeFavelier commented Dec 19, 2019

I'm not authorized to merge this pull request, I let you take care of it.

@banesullivan
Copy link
Copy Markdown
Member

banesullivan commented Dec 19, 2019

Oh weird... I thought you were

@banesullivan banesullivan merged commit 45b74ea into master Dec 19, 2019
@banesullivan banesullivan mentioned this pull request Dec 20, 2019
Closed
@banesullivan banesullivan deleted the fix_add_slider_widget branch December 23, 2019 15:55
@GuillaumeFavelier GuillaumeFavelier mentioned this pull request Dec 24, 2019
Merged
5 tasks
@GuillaumeFavelier GuillaumeFavelier mentioned this pull request Mar 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@banesullivan banesullivan banesullivan approved these changes

Assignees

@GuillaumeFavelier GuillaumeFavelier

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GuillaumeFavelier @banesullivan