Weird that my example caused it to fail since I only modified the examples. Potentially due to a change in master?

I noticed that it's possible to add multiple floors with add_floor() but you can only remove the last one with remove_floor()

I noticed that it's possible to add multiple floors with add_floor() but you can only remove the last one with remove_floor()

Indeed - this still needs to be worked out

I noticed that it's possible to add multiple floors with add_floor() but you can only remove the last one with remove_floor()

With more thoughts, I think it depends on the API for it. What would be best?

• one call to remove_floor() for each call to add_floor()
• one call to remove_floor(all=True) or remove_floors() to remove everything

Codecov Report

Merging #423 into master will decrease coverage by 0.15%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
- Coverage   84.50%   84.35%   -0.16%     
==========================================
  Files          34       34              
  Lines        9264     9344      +80     
==========================================
+ Hits         7829     7882      +53     
- Misses       1435     1462      +27     

I noticed that it's possible to add multiple floors with add_floor() but you can only remove the last one with remove_floor()

With more thoughts, I think it depends on the API for it. What would be best?

• one call to remove_floor() for each call to add_floor()
• one call to remove_floor(all=True) or remove_floors() to remove everything

I went ahead and implemented remove_floors as it's the cleanest API, and there's not a good way to track which floor is removed. Full example is:

import pyvista as pv
from pyvista import examples

mesh = examples.download_dragon()

p = pv.Plotter()
p.add_mesh(mesh)
p.add_floor('-y')
p.add_floor('-z')
p.remove_floors()
p.show()

Which will just plot the dragon.