When data_or_wLength is an array, keep the same object (alt fix)#529
Closed
kauwua wants to merge 1 commit intopyusb:masterfrom
Closed
When data_or_wLength is an array, keep the same object (alt fix)#529kauwua wants to merge 1 commit intopyusb:masterfrom
kauwua wants to merge 1 commit intopyusb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alt fix proposed in #527.
In
v1.2.1, when data_or_wLength was an array, aTypeErrorexception was triggered increate_bufferwhich means_interop.as_arraywas called and the same array object was used (modified in-place as expected).In
v1.3.0, commit 3ea79b0 introduced a change increate_bufferthat does not trigger theTypeErrorexception and instead creates a new array from the one passed indata_or_wLength.This means a new array is created and receives data for IN transfers, not the array passed as argument.