-
Notifications
You must be signed in to change notification settings - Fork 671
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: pyusb/pyusb
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.3.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: pyusb/pyusb
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.3.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 8 commits
- 8 files changed
- 1 contributor
Commits on Jan 1, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 8acb57e - Browse repository at this point
Copy the full SHA 8acb57eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b153a2 - Browse repository at this point
Copy the full SHA 2b153a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0573e84 - Browse repository at this point
Copy the full SHA 0573e84View commit details
Commits on Jan 8, 2025
-
util: raise TypeError if create_buffer doesn't receive a length
`Device.ctrl_transfer` depends on `create_buffer` raising a `TypeError` if its parameter is not a valid length. In particular, if an array is passed in, `create_buffer` must *not* return a copy of it. Commit 3ea79b0 accidentally broke this and, consequently, any calls to `ctrl_transfer` passing in a buffer. Thanks @kauwua for reporting the issue and discussing the potential solutions. Note that `length * b'\x00'` is actually faster than `bytes(length)` (tested with Python 3.13 on x86_64). Fixes: #528 Fixes: 3ea79b0 ("util: remove left over python 2 compatibility workaround")
Configuration menu - View commit details
-
Copy full SHA for 5d73f3d - Browse repository at this point
Copy the full SHA 5d73f3dView commit details -
interop: prioritize no-op case but also accept length for a new array
While discussing #527, @kauwua made the valid point that we could optimize for the case where the user has passed in a byte `array`. In that spirit, prioritize the no-op conversion case, but also accept the parameter to be a length for a new array in preparation for replacing the conditional in `Device.ctrl_transfer`. Related: #528
Configuration menu - View commit details
-
Copy full SHA for 0d578a2 - Browse repository at this point
Copy the full SHA 0d578a2View commit details -
core: replace try-except block with single call to new _interop.as_array
Configuration menu - View commit details
-
Copy full SHA for e920187 - Browse repository at this point
Copy the full SHA e920187View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2b6bb8 - Browse repository at this point
Copy the full SHA f2b6bb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89ea84d - Browse repository at this point
Copy the full SHA 89ea84dView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.3.0...v1.3.1