Skip to content

Add EMIT emit_l1b reader#2592

Draft
zxdawn wants to merge 9 commits into
pytroll:mainfrom
zxdawn:emit_l1b
Draft

Add EMIT emit_l1b reader#2592
zxdawn wants to merge 9 commits into
pytroll:mainfrom
zxdawn:emit_l1b

Conversation

@zxdawn

@zxdawn zxdawn commented Oct 8, 2023

Copy link
Copy Markdown
Member
  • Tests added
  • Fully documented

This PR supports reading the EMIT L1B NetCDF file provided by JPL.

@codecov

codecov Bot commented Oct 8, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 34.06593% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.07%. Comparing base (f018f12) to head (760ac6a).
⚠️ Report is 3329 commits behind head on main.

Files with missing lines Patch % Lines
satpy/readers/emit_l1b.py 34.06% 60 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2592      +/-   ##
==========================================
+ Coverage   94.92%   95.07%   +0.15%     
==========================================
  Files         352      355       +3     
  Lines       51225    51361     +136     
==========================================
+ Hits        48624    48834     +210     
+ Misses       2601     2527      -74     
Flag Coverage Δ
behaviourtests 4.23% <0.00%> (-0.05%) ⬇️
unittests 95.70% <34.06%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zxdawn zxdawn self-assigned this Oct 8, 2023
@zxdawn zxdawn requested a review from simonrp84 October 8, 2023 14:09
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 6448022511

  • 25 of 68 (36.76%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 95.414%

Changes Missing Coverage Covered Lines Changed/Added Lines %
satpy/readers/emit_l1b.py 25 68 36.76%
Totals Coverage Status
Change from base Build 6426189025: -0.08%
Covered Lines: 48772
Relevant Lines: 51116

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants