Add flag to enable activation sharding#55
Merged
wonjoo-wj merged 4 commits intooptimize_spmd_shardingfrom Mar 20, 2024
Merged
Conversation
yeounoh
reviewed
Mar 20, 2024
yeounoh
reviewed
Mar 20, 2024
Collaborator
Author
|
@yeounoh, I've updated the code to dynamically fetch the num_device, device_ids, mesh_shape by calculating num_device outside of the torch.compile'd function. Verified that now it properly accepts the argument I'll go ahead and merge this for now and follow-up if there are any other things to address. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, you can add flag
--enable_activation_sharding Trueto your command to enable activation sharding. By default, this is set to false.