Conversation
4864df4 to
389e63c
Compare
zhanyong-wan
reviewed
Aug 6, 2025
zhanyong-wan
reviewed
Aug 6, 2025
zhanyong-wan
requested changes
Aug 6, 2025
…CHECK*()` macros' implementation. Replaces the XLA debug macro implementation to use PyTorch's `TORCH_CHECK` instead of throwing `std::runtime_error` directly, which makes it so `XLA_CHECK*()` macros show PyTorch C++ stacktrace. Key changes: - Updated tf_logging.cpp to use `TORCH_CHECK` instead of `std::runtime_error` - Updated test to match new PyTorch stacktrace format - Deprecated `ConsumeValue` function in favor of `GetValueOrThrow`
c14318f to
32475c8
Compare
zhanyong-wan
requested changes
Aug 7, 2025
Collaborator
Author
|
Here's a quick summary of the last commits:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the XLA debug macro implementation to use PyTorch's
TORCH_CHECKinstead of throwingstd::runtime_errordirectly, which makes it soXLA_CHECK*()macros show PyTorch C++ stacktrace.Key changes:
TORCH_CHECKinstead ofstd::runtime_errorTHROW_RUNTIME_ERROR_FROM_C10_ERRORmacro to cpp_test_utils.h, and added_to its name, indicating an implementation internal macroXLA_CHECK*()macrosGetComputationClientOrDie()(at runtime.h) deprecation warning