Conversation
ysiraichi
commented
Jul 25, 2025
zhanyong-wan
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors error handling for
GetXlaTensor()and related functions (e.g.TryGetXlaTensor(),TryGetXlaTensors(), andReplaceXlaTensor()), by incorporating status types. At this moment, these changes do not translate into better UX for the user. However, this PR lays the groundwork for improving that.Key Changes
GetXlaTensor()returns aStatusOr<XLATensorPtr>TryGetXlaTensor()in favor ofGetXlaTensor()GetXlaTensor()TryGetXlaTensors()(note the plural)GetXlaTensor()ReplaceXlaTensor(), returningabsl::StatusGetXlaTensor()calls withGetValueOrThrow(GetXlaTensor())(same forGetXlaTensors()-- plural)ReplaceXlaTensor()calls withMaybeThrow(ReplaceXlaTensor())