Move mutable properties of env to thread local, misc changes#9501
Merged
Move mutable properties of env to thread local, misc changes#9501
Conversation
Collaborator
qihqi
commented
Jul 23, 2025
- refactored a bit of jax default device. Now it respects whatever user sets with jax.default_device
zzzwen
approved these changes
Jul 23, 2025
Collaborator
zzzwen
left a comment
There was a problem hiding this comment.
I think you need to remove the UT relating to jax_device as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.