Improve error message for shape promotion on lowering.#9486
Merged
Improve error message for shape promotion on lowering.#9486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves error messages for shape promotion during XLA operation lowering and refactors relevant call sites to use
GetValueOrThrow().Key Changes:
XlaHelpers::GetPromotedShape()function for promoting shapes now provide more specific shape information, detailing what's invalid.Statusfor shape promotion error handling: The functionXlaHelpers::GetPromotedShape()now returns aStatusOr<Shape>data type for better error handling.GetValueOrThrow()Adaptation: Call sites have been updated to useGetValueOrThrow()for more consistent error handling.