Skip to content

Rename XLA_SHOW_CPP_ERROR_CONTEXT to TORCH_SHOW_CPP_STACKTRACES#9482

Merged
ysiraichi merged 9 commits intomasterfrom
ysiraichi/rename-error-context-env-var
Jul 17, 2025
Merged

Rename XLA_SHOW_CPP_ERROR_CONTEXT to TORCH_SHOW_CPP_STACKTRACES#9482
ysiraichi merged 9 commits intomasterfrom
ysiraichi/rename-error-context-env-var

Conversation

@ysiraichi
Copy link
Copy Markdown
Collaborator

This PR renames the environment variable XLA_SHOW_CPP_ERROR_CONTEXT to TORCH_SHOW_CPP_STACKTRACES for consistency with existing PyTorch development practices.

Key Changes

  • Alongside with the environment variable name, kEnvShowCppErrorContext variable (in env_vars.h) was also renamed to kEnvShowCppStacktraces
  • Test files, enums, and functions were also renamed accordingly

Rename `XLA_SHOW_CPP_ERROR_CONTEXT` to `TORCH_SHOW_CPP_STACKTRACES`.
@ysiraichi ysiraichi requested review from ghpvnist and zhanyong-wan and removed request for zhanyong-wan July 15, 2025 18:44
Copy link
Copy Markdown
Collaborator

@ghpvnist ghpvnist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment thread torch_xla/csrc/runtime/env_vars.h Outdated
Copy link
Copy Markdown
Collaborator

@zhanyong-wan zhanyong-wan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread torch_xla/csrc/status.cpp Outdated
@ysiraichi ysiraichi merged commit 58592c4 into master Jul 17, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants